Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update Binary-Artifacts and License checks #4079

Merged
merged 6 commits into from
May 3, 2024
Merged

🌱 Update Binary-Artifacts and License checks #4079

merged 6 commits into from
May 3, 2024

Commits on May 3, 2024

  1. replaced localRepoClient with mockRepoClient 

    Signed-off-by: seelder <seelder@ncsu.edu>
    @seelder
    seelder committed May 3, 2024
    Configuration menu
    Copy the full SHA
    37c66cf View commit details
    Browse the repository at this point in the history

  2. Update binary_artifact_test.go to use scut 

    Updated the test to use scut. Updated the test data to use scut, including adding NumberOfInfo and NumberOfWarn for each test case

Signed-off-by: seelder <seelder@ncsu.edu>
    @seelder
    seelder committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3b34ffe View commit details
    Browse the repository at this point in the history

  3. Update license_test to use gomock 

    First attempt at updating license_test to use gomock instead of localDir.

Note: localDir currently has a TODO for implementing ListLicenses.  It returns an UnsupportedFeatures error, which is then handled in checks/raw/license. This first attempt replicates that existing behavior.
Signed-off-by: seelder <seelder@ncsu.edu>
    @seelder
    seelder committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f4f4319 View commit details
    Browse the repository at this point in the history

  4. Update license_test documentation 

    Clarified why the mock simply throws an error

Signed-off-by: seelder <seelder@ncsu.edu>
    @seelder
    seelder committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e825531 View commit details
    Browse the repository at this point in the history

  5. Fixed linting error in license_test 

    Signed-off-by: seelder <seelder@ncsu.edu>
    @seelder
    seelder committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6f2e541 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ossf:main' into main 

    Signed-off-by: seelder <seelder@ncsu.edu>
    @seelder
    seelder committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a6a7e59 View commit details
    Browse the repository at this point in the history