-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Add ProjectPackageVersions to raw data collection #4104
⚠️ Add ProjectPackageVersions to raw data collection #4104
Conversation
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remind me what the intended purpose is? There's a lot of data being added to the raw results. But hard to reason about the necessity of it when there's no accompanying probe.
If we consider the ossf/scorecard response for example:
https://api.deps.dev/v3/projects/github.com%2Fossf%2Fscorecard:packageversions
The probe will be something like |
/scdiff generate Signed-Releases |
Getting segfaults and e2e test failures, which would need to be fixed. I'm also curious how errors in the deps dev response would be handled right now (if it would mess up other data collection) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4104 +/- ##
==========================================
- Coverage 66.06% 59.96% -6.11%
==========================================
Files 226 214 -12
Lines 16291 15551 -740
==========================================
- Hits 10763 9325 -1438
- Misses 4854 5535 +681
- Partials 674 691 +17 |
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
They're propagated up to the check level, so they'll cause the check to fail. |
/scdiff generate Signed-Releases |
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
/scdiff generate Signed-Releases |
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
/scdiff generate Signed-Releases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good. I think the cron client (as-is) will panic on a nil pointer deref, so let's fix that.
Signed-off-by: Raghav Kaul <raghavkaul+github@google.com>
What kind of change does this PR introduce?
Adds ProjectPackageVersion data to
SignedReleasesData
, which will let a probe consume the data. Also add mock forProjectPackageClient
.Repo
interface must now implementPath()
.