-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Improve the REUSE parts of the License check #4155
📖 Improve the REUSE parts of the License check #4155
Conversation
fc335ab
to
5a35ab5
Compare
Signed-off-by: Max Mehl <mail@mehl.mx>
Signed-off-by: Max Mehl <mail@mehl.mx>
Signed-off-by: Max Mehl <mail@mehl.mx>
5a35ab5
to
a4a33a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run make generate-docs
and commit the changes to docs/checks.md
?
docs/checks/internal/checks.yaml
is the correct place to make changes, but the markdown needs to be generated too.
Sure, done, sorry for not doing that in the first place. |
Thanks! You'll need to fix your DCO on your last commit and then we can merge. https://github.com/ossf/scorecard/pull/4155/checks?check_run_id=25990600837 |
Signed-off-by: Max Mehl <mail@mehl.mx>
c75342a
to
8fb1005
Compare
Whoops, done, thanks! |
What kind of change does this PR introduce?
This PR contains three changes concerning the REUSE part of the License check:
The third point needs your review as I am not certain how the tool checks for license files. As the docs also recommend putting license files in
LICENSES
, this SHOULD be the case.What is the current behavior?
What is the new behavior (if this is a feature change)?**
The check documentation and the recommendations are unclear and partly misleading.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?