Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add stack info to osv-scanner error #4172

Merged
merged 3 commits into from
Jun 14, 2024
Merged

🌱 add stack info to osv-scanner error #4172

merged 3 commits into from
Jun 14, 2024

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Jun 13, 2024

What kind of change does this PR introduce?

feature

What is the current behavior?

only print a error string for osv-scanner panic error

What is the new behavior (if this is a feature change)?**

also print the stacktrace

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Updates #4171

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

@Zxilly Zxilly requested a review from a team as a code owner June 13, 2024 16:38
@Zxilly Zxilly requested review from naveensrinivasan and spencerschrock and removed request for a team June 13, 2024 16:38
clients/osv.go Outdated Show resolved Hide resolved
@Zxilly
Copy link
Contributor Author

Zxilly commented Jun 14, 2024

One e2e test failed, reaching Github speed limit, not related with this patch.

Zxilly added 3 commits June 15, 2024 02:30
Signed-off-by: Zxilly <zxilly@outlook.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
Signed-off-by: Zxilly <zxilly@outlook.com>
@spencerschrock spencerschrock merged commit 5ef9831 into ossf:main Jun 14, 2024
36 checks passed
@spencerschrock
Copy link
Member

Thank you!

@Zxilly
Copy link
Contributor Author

Zxilly commented Jun 16, 2024

I'm wondering when will we got a new release.

@Zxilly Zxilly deleted the panic-cover branch June 17, 2024 17:36
@spencerschrock
Copy link
Member

I'm wondering when will we got a new release.

For our CLI and action, we are targeting end of the month for the full, non-release candidate v5. This code is already deployed in our infrastructure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants