Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use RepoClient.Search API in SAST check #857

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Update SAST check to use the new RepoClient.Search API.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

@github-actions
Copy link

Integration tests success for d11548493bc137e2127b350c7b85478eedf3fa27

@azeemshaikh38 azeemshaikh38 force-pushed the azeems/api branch 2 times, most recently from a698846 to 744da4a Compare August 14, 2021 04:01
@github-actions
Copy link

Integration tests failure for a698846908f14b15a683d737438cecb3cd58a830

@github-actions
Copy link

Integration tests success for 744da4a7baef9a160ee3438e1a52b97874d0322a

clients/githubrepo/search.go Outdated Show resolved Hide resolved
clients/githubrepo/search.go Outdated Show resolved Hide resolved
Copy link
Contributor

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM with few fixes needed.

clients/githubrepo/search.go Outdated Show resolved Hide resolved
clients/githubrepo/search.go Outdated Show resolved Hide resolved
clients/githubrepo/search.go Outdated Show resolved Hide resolved
clients/githubrepo/search.go Show resolved Hide resolved
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

Integration tests success for a9e53adbb0337bed894dfc3ddf7fb4f17b6a6ec4

@github-actions
Copy link

Integration tests success for ffd9d2fed255d5fadd663313e09d12232fe67625

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) August 16, 2021 16:38
@github-actions
Copy link

Integration tests success for a21947e97c961ee31c94580829aef505a2475e8d

@azeemshaikh38 azeemshaikh38 merged commit 13ef9dd into main Aug 16, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/api branch August 16, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants