Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add ephemeral-storage to cron worker #885

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Conversation

azeemshaikh38
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Cron workers were getting evicted since no ephemeral storage was requested. Explicitly requesting ephemeral-storage to avoid this.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No.

Copy link
Contributor

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use more :) 100/500 is fine as well

@github-actions
Copy link

Integration tests success for feab9d192e32b29a49bf0f49e737a80c22d53d31

Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the https://kubernetes.io/docs/concepts/storage/volumes/#emptydir that is causing ephemeralstorage to get filled up. I agree with @inferno-chromium we should probably go higher.

@azeemshaikh38
Copy link
Contributor Author

Use more :) 100/500 is fine as well

Done.

@azeemshaikh38
Copy link
Contributor Author

It is the https://kubernetes.io/docs/concepts/storage/volumes/#emptydir that is causing ephemeralstorage to get filled up. I agree with @inferno-chromium we should probably go higher.

That makes more sense. Thanks!

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) August 23, 2021 21:18
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

Integration tests success for c074b6119e074c7376afb0c4d6d58ab1e08a7acf

@github-actions
Copy link

Integration tests success for 78bdc9856db1d2f19e4ca2c02a365c3c4b69cc76

@azeemshaikh38 azeemshaikh38 merged commit aea1249 into main Aug 23, 2021
@azeemshaikh38 azeemshaikh38 deleted the azeems/storage branch August 23, 2021 22:27
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants