✨ Decouple scorecard json from cron json #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
use same json for cron and scorecard
What is the new behavior (if this is a feature change)?
separate the two json. This way we can change the scorecard JSON format without affecting the cron job.
We already decoupled the scorecard JSON format from the internal scorecard structure used to store result. This is the next step.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:
This PR blocks ✨ Improve JSON format #934. I will add schema validation and unit tests once we have migrated the cron JSON to be the same as ✨ Improve JSON format #934