Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): print the correct next version in the log message #55

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Aug 30, 2023

When running the publish command normally, the following log call doesn't print the next package version correctly:

this.log.info('bumped version in package.json to:', nextVersion)

This is because pino doesn't seem to support the multi-argument way to compose the logged message. Instead, the entire computed message must be provided to it at once, like it's done in other logs with the format() function.

@kettanaito kettanaito force-pushed the fix/dry-run-version-log branch 2 times, most recently from 98bc76e to fc1e86d Compare August 30, 2023 15:52
@kettanaito kettanaito merged commit b0f370a into main Aug 30, 2023
1 check passed
@kettanaito kettanaito deleted the fix/dry-run-version-log branch August 30, 2023 15:57
@kettanaito
Copy link
Member Author

Released: v0.5.2 🎉

This has been released in v0.5.2!

Make sure to always update to the latest version (npm i @ossjs/release@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant