Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix efidisk including discard=on #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jclab-joseph
Copy link

No description provided.

@wdoekes
Copy link
Member

wdoekes commented Oct 5, 2022

Thanks for this changeset.

Why is this? Does setting discard on the efidisk not work? How does that manifest itself?

Also, maybe we want (old)slot passed to ProxmoxVolume, so we can inspect it for /efidisk/ there instead of having to pass no_discard around.

@jclab-joseph
Copy link
Author

2022-10-05 16:59:28,097: INFO: Begin copy of 'efidisk0' (local-lvm:vm-9010-disk-1,size=4M) to pve-ds01 (vm-20024-disk-0)
2022-10-05 16:59:28,283: INFO: Volume transferring/conversion 100% (is/was) complete!
2022-10-05 16:59:28,300: ERROR: Issue when adding volume to new VM: 'pve-ds01:vm-20024-disk-0,discard=on,size=4M'
Traceback (most recent call last):
  File "/root/proxmove-main/./proxmove", line 1810, in create_volume
    self.api_vm.config.put(**{volume_key: new_properties})
  File "/usr/lib/python3/dist-packages/proxmoxer/core.py", line 90, in put
    return self(args)._request("PUT", data=data)
  File "/usr/lib/python3/dist-packages/proxmoxer/core.py", line 78, in _request
    raise ResourceException("{0} {1}: {2}".format(resp.status_code, httplib.responses[resp.status_code],
proxmoxer.core.ResourceException: 400 Bad Request: b'{"errors":{"efidisk0":"invalid format - format error\\nefidisk0.discard: property is not defined in schema and the schema does not allow additional properties\\n"},"data":null}'
Traceback (most recent call last):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants