Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time unit incorrect in comments #3976

Open
suzp1984 opened this issue Mar 6, 2024 · 1 comment
Open

time unit incorrect in comments #3976

suzp1984 opened this issue Mar 6, 2024 · 1 comment
Assignees
Labels
EnglishNative This issue is conveyed exclusively in English.

Comments

@suzp1984
Copy link
Contributor

suzp1984 commented Mar 6, 2024

The time unit incorrect

// The time unit in ms, for example 120 * SRS_UTIME_SECONDS means 120s.

time unit ms should be seconds.

// The time unit in **seconds**, for example 120 * SRS_UTIME_SECONDS means 120s.   ->
#define SRS_UTIME_SECONDS 1000000LL

srsu2si: convert long long to int

#define srsu2si(us) ((us) / SRS_UTIME_SECONDS)

#define srsu2si(us) ((us) / SRS_UTIME_SECONDS) ->
#define srsu2si(us) int ((us) / SRS_UTIME_SECONDS)

Version
All SRS version

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Mar 6, 2024
suzp1984 added a commit to suzp1984/srs that referenced this issue Mar 6, 2024
@winlinvip
Copy link
Member

Nice work. Thank you.

@winlinvip winlinvip self-assigned this Mar 18, 2024
winlinvip pushed a commit to suzp1984/srs that referenced this issue Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants