Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTMP: Response accurate error when rejecting OBS. #4037

Closed
winlinvip opened this issue Apr 22, 2024 · 0 comments · Fixed by #4038
Closed

RTMP: Response accurate error when rejecting OBS. #4037

winlinvip opened this issue Apr 22, 2024 · 0 comments · Fixed by #4038
Assignees
@winlinvip
Labels
EnglishNative This issue is conveyed exclusively in English.

Comments

@winlinvip
Copy link
Member

winlinvip commented Apr 22, 2024 •
edited
Loading

alexanderh5453:
Same error is present when trying to stream to a Twitch server

If use invalid key publishing to twitch.tv, failed with message:

Image

No special error message sent from twitch.tv to OBS:

Image

twitch-obs-fail.pcapng.zip
twitch-obs-ok.pcapng.zip

SRS responsed the onStatus(NetStream.Publish.Start) message before close the TCP connection when hooks failed, which cause the OBS reconnecting again and again.

srs.obs.fail.pcapng.zip

But please note that twitch.tv never response error message, and OBS/FFmpeg never handle the error message.
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Apr 22, 2024
@winlinvip winlinvip changed the title NoETA: Response accurate error when rejecting OBS. Response accurate error when rejecting OBS. Apr 22, 2024
@winlinvip winlinvip closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@winlinvip winlinvip reopened this Apr 23, 2024
@winlinvip winlinvip transferred this issue from ossrs/oryx Apr 23, 2024
@winlinvip winlinvip self-assigned this Apr 23, 2024
@winlinvip winlinvip changed the title Response accurate error when rejecting OBS. RTMP: Response accurate error when rejecting OBS. Apr 23, 2024
@winlinvip winlinvip mentioned this issue Apr 23, 2024
Merged
winlinvip added a commit that referenced this issue Apr 23, 2024
@winlinvip
RTMP: Do not response publish start message if hooks fail. v5.0.212 v…
37f0faa 
…6.0.123 (#4038)

Fix #4037 SRS should not send the publish start message
`onStatus(NetStream.Publish.Start)` if hooks fail, which causes OBS to
repeatedly reconnect.

Note that this fix does not send an RTMP error message when publishing
fails, because neither OBS nor FFmpeg process this specific error
message; they only display a general error.

Apart from the order of messages, nothing else has been changed.
Previously, we sent the publish start message
`onStatus(NetStream.Publish.Start)` before the HTTP hook `on_publish`;
now, we have modified it to send this message after the HTTP hook.
winlinvip added a commit that referenced this issue Apr 23, 2024
@winlinvip
RTMP: Do not response publish start message if hooks fail. v5.0.212 (#…
9995147 
…4038)

Fix #4037 SRS should not send the publish start message
`onStatus(NetStream.Publish.Start)` if hooks fail, which causes OBS to
repeatedly reconnect.

Note that this fix does not send an RTMP error message when publishing
fails, because neither OBS nor FFmpeg process this specific error
message; they only display a general error.

Apart from the order of messages, nothing else has been changed.
Previously, we sent the publish start message
`onStatus(NetStream.Publish.Start)` before the HTTP hook `on_publish`;
now, we have modified it to send this message after the HTTP hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
Oryx Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RTMP: Do not response publish start message if hooks fail. v5.0.212 v6.0.123 winlinvip/srs
1 participant
@winlinvip