Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in edge mode. #2967

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

fix crash in edge mode. #2967

wants to merge 17 commits into from

Conversation

johzzy
Copy link
Contributor

@johzzy johzzy commented Mar 14, 2022

Summary

fix crash in edge mode.

Details

crash if run edge, use conf/edge.conf or this config

    cluster {
        mode remote;
        origin xxx;
    }

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #2967 (6a06989) into develop (1a6d94a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 6a06989 differs from pull request most recent head 8281e66. Consider uploading reports for the commit 8281e66 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2967   +/-   ##
========================================
  Coverage    56.10%   56.10%           
========================================
  Files          153      153           
  Lines        57561    57559    -2     
========================================
  Hits         32294    32294           
+ Misses       25267    25265    -2     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_threads.cpp | 63.70% <ø> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_threads.cpp | 63.70% <ø> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 1a6d94a...8281e66. Read the comment docs.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Mar 14, 2022

Please provide more background information.

  1. The code fix is for a problem with a call.
  2. The configuration and reproduction steps are just a normal edge configuration.
  3. It is not clear what exactly happened.

TRANS_BY_GPT3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It might be a bug. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants