-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H265: Demux sps for log print and statistic streams.(#3271) #3286
H265: Demux sps for log print and statistic streams.(#3271) #3286
Conversation
e67f095
to
565ceb3
Compare
|
||
if (profile_resent_flag) { | ||
if (!bs->require(88)) { | ||
return srs_error_new(ERROR_HEVC_DECODE_ERROR, "ptl general profile tier shall atleast 88bits"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an implicit variable here, which is the actual remaining bits. So the error message should include this information.
return srs_error_new(ERROR_HEVC_DECODE_ERROR, "ptl requires 88 only %d bits", bs->bits_left());
Note: There is no need to write so many constants. The errors already include line numbers and functions, so we only need a descriptive constant. Therefore, instead of
ptl general profile tier shall atleast
, it can be directly changed toptl requires
orptl profile requires
.
Please also make changes in other places.
TRANS_BY_GPT3
When you experience
./configure --h265=on
, print detail codec infomation and statistic streams. Likely,curl "http://127.0.0.1:1985/api/v1/streams/"