-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve the problem of inaccurate HLS TS duration. v5.0.187 v6.0.87 #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The comment on the ratio configuration says it can affect the slice duration, but there is no effect after configuring it. 2. The default hls_td_ratio is 1.5, and after setting it to 1, the duration is still slightly more than 10 seconds. 3. Even if the GOP is an integer, like 1 second, the slice is still a non-integer, like 0.998 seconds, which seems a bit unreliable. 4. In the duration of the TS in the m3u8 file, it is one frame less than the duration of the slice.
We need to merge into 5 and 6.
|
xiaozhihong
approved these changes
Oct 8, 2023
xiaozhihong
changed the title
Solve the problem of inaccurate HLS TS duration
Solve the problem of inaccurate HLS TS duration. v6.0.86
Oct 8, 2023
xiaozhihong
force-pushed
the
bugfix/hls-ts-duration
branch
from
October 8, 2023 13:40
1eccd19
to
45dace4
Compare
xiaozhihong
changed the title
Solve the problem of inaccurate HLS TS duration. v6.0.86
Solve the problem of inaccurate HLS TS duration. v5.0.185 v6.0.87
Oct 8, 2023
xiaozhihong
force-pushed
the
bugfix/hls-ts-duration
branch
from
October 8, 2023 14:29
b097857
to
d9da8a9
Compare
xiaozhihong
changed the title
Solve the problem of inaccurate HLS TS duration. v5.0.185 v6.0.87
Solve the problem of inaccurate HLS TS duration. v5.0.187 v6.0.87
Oct 8, 2023
xiaozhihong
force-pushed
the
bugfix/hls-ts-duration
branch
from
October 8, 2023 14:38
a18df05
to
e139a86
Compare
xiaozhihong
approved these changes
Oct 9, 2023
winlinvip
pushed a commit
that referenced
this pull request
Oct 9, 2023
duiniuluantanqin
pushed a commit
to duiniuluantanqin/srs
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch:
After this patch:
Note: If the fragment is set to 10 seconds, but the GOP size cannot be divided by 10, such as not 1, 2, 5, or 10, then the duration of ts will still be more than 10 seconds.
Co-authored-by: john hondaxiao@tencent.com