Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed process crash on message handler #214

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

fraliv13
Copy link
Collaborator

@fraliv13 fraliv13 commented Mar 4, 2022

The process crashes when publishing to the dead letter queue, usually when a publish decorator throws an exception. It only crashes when the code that throws the error is executed synchronously (without/before calling await).

The issue was caused because an exception was thrown in an "async void" method in the nats transport implementation. For details see this link

The fix was to replace the "async void" method with Task fire and forget.
Other changes:

  • more robust error handling when pushing to DLQ
  • force the message bus publishing in DLQ to execute asynchronously(non- blocking)

Fixed multiple publications to soter
@fraliv13 fraliv13 merged commit d6c9c1d into master Mar 16, 2022
@fraliv13 fraliv13 deleted the feature/messaging-process-crash branch March 16, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process killed when a deserialization error occurred in messaging host
2 participants