Feature/gob #47
Merged
Feature/gob #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y normalized inside Set()
Repository owner
deleted a comment from
codecov-commenter
May 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 83.91% 83.56% -0.35%
==========================================
Files 9 11 +2
Lines 976 1290 +314
==========================================
+ Hits 819 1078 +259
- Misses 108 150 +42
- Partials 49 62 +13
Continue to review full report at Codecov.
|
segfault99
suggested changes
May 7, 2022
README.md
Outdated
| @@ -188,6 +188,48 @@ db.Query("todos").UpdateById(docId, map[string]interface{}{"completed": true}) | |||
| db.Query("todos").DeleteById(docId) | |||
| ``` | |||
|
|
|||
| ## Data Types | |||
|
|
|||
| Internally, CloverDB supports the following primitive data types: **int64**, **uint64**, **float64** and **time.Time**. When possible, values having different types are silently converted to one of the internal types: signed integer values get converted to int64, while unsigned ones to uint64. Float32 values are extended to float64. | |||
There was a problem hiding this comment.
you could also add string to the primitive data types
There was a problem hiding this comment.
Yes, I forgot to add string and bool to the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #46. Need to add exhaustive tests and improve code before merging