Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: Inherit previous kargs by default #502

Closed
cgwalters opened this issue Jul 19, 2023 · 0 comments · Fixed by #503
Closed

deploy: Inherit previous kargs by default #502

cgwalters opened this issue Jul 19, 2023 · 0 comments · Fixed by #503

Comments

@cgwalters
Copy link
Member

Today ostree container image deploy doesn't preserve previous deployment kargs, it only preserves booted:

ostree-rs-ext/lib/src/container/deploy.rs

Line 86 in c2a292c

override_kernel_argv: options.kargs,

This is a huge ergonomic problem for coreos/fedora-coreos-tracker#1151 (comment)
cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this issue Jul 19, 2023
@cgwalters
deploy: Don't overwrite kargs by default
77f04e7 
This is the same bug as
ostreedev@3089166
but for the not-booted case.

Basically in the C API bridged to Rust we can't distinguish between
"NULL array" and "zero length array".  But the _with_options path
supports distinguishing them, and we want the "no kargs provided"
case to not override anything.

Closes: ostreedev#502
@cgwalters cgwalters mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deploy: Don't overwrite kargs by default cgwalters/ostree-rs-ext
1 participant
@cgwalters