Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ostree container image deploy don't support composefs=signed #633

Closed
jbtrystram opened this issue May 29, 2024 · 1 comment · Fixed by #635
Closed

ostree container image deploy don't support composefs=signed #633

jbtrystram opened this issue May 29, 2024 · 1 comment · Fixed by #635

Comments

@jbtrystram
Copy link

jbtrystram commented May 29, 2024 •
edited
Loading

While working on a POC enabling a signed composeFS in coreos-assembler I get the following error at the ostree container image deploy step:

error: Reading composefs config: Loading composefs config: Invalid tri-state value: signed

See coreos/coreos-assembler#3813 (comment) for more details

EDIT: Ah, sorry I should have opened the issue against the ostree repo
@cgwalters
Copy link
Member

EDIT: Ah, sorry I should have opened the issue against the ostree repo

This is the correct repo actually because this code has a different parser it's broken here

cgwalters added a commit to cgwalters/ostree-rs-ext that referenced this issue May 29, 2024
@cgwalters
prepareroot: Also accept composefs enabled=signed
ab3e9df 
This was an oversight, unfortunately having two different
programming languages here led to less code sharing.

Closes: ostreedev#633
@cgwalters cgwalters mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prepareroot: Also accept composefs enabled=signed cgwalters/ostree-rs-ext
2 participants
@cgwalters @jbtrystram