Skip to content

Commit

Permalink
lib/repo: Drop outdated FIXME comment from ostree-repo.h
Browse files Browse the repository at this point in the history
This was some incomplete planning from while the find_remotes() API was
being designed; now totally outdated.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
  • Loading branch information
pwithnall committed Sep 15, 2017
1 parent a7df6fe commit 823b647
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions src/libostree/ostree-repo.h
Original file line number Diff line number Diff line change
Expand Up @@ -1156,33 +1156,6 @@ ostree_repo_pull_one_dir (OstreeRepo *self,
GCancellable *cancellable,
GError **error);



#if 0
FIXME
Called with: remote_name, refs, override-commit-ids
or: URL, refs, override-commit-ids
=> we only need refs; could use the remote_name or URL as additional results

Summary file is downloaded first, so this would result in multiple downloads of
the summary, but we dont care because of caching.

Big problem preventing this from being the overall API: presenting the download
sizes in the gnome-software UI before the user chooses to download.

_OSTREE_PUBLIC
gboolean ostree_repo_find_remotes_squashed (OstreeRepo *self,
const gchar * const *refs, -> options
GVariant *options,
OstreeRepoFinder **finders, -> options
GMainContext *context, -> nope
OstreeAsyncProgress *progress,
GCancellable *cancellable,
GError **error);
#endif



_OSTREE_PUBLIC
gboolean ostree_repo_pull_with_options (OstreeRepo *self,
const char *remote_name_or_baseurl,
Expand Down

0 comments on commit 823b647

Please sign in to comment.