Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ostree-system-generator failed with exit status 1 #2909

Closed
Freyon77 opened this issue Jun 27, 2023 · 4 comments · Fixed by #2911
Closed

Ostree-system-generator failed with exit status 1 #2909

Freyon77 opened this issue Jun 27, 2023 · 4 comments · Fixed by #2911

Comments

@Freyon77
Copy link

Arch x86_64

Every boot error message appear in journalctl. Sometimes error message shows randomly, but not sure what trigger it.

(sd-execu[4034]: /usr/lib/systemd/system-generators/ostree-system-generator failed with exit status 1.
@Freyon77 Freyon77 changed the title Ostre-system-generator failed with exit status 1 Ostree-system-generator failed with exit status 1 Jun 27, 2023
@Freyon77
Copy link
Author

Affected fedora users too

@chrisawi
Copy link

I saw a user report this earlier and meant to relay it here, but I got distracted by the flatpak issue.

Since aa72caf, that generator no longer exits 0 when not ostree-booted. The comment describing the intended behavior is still present:

  /* If we're installed on a system which isn't using OSTree for boot (e.g.
   * package installed as a dependency for flatpak or whatever), silently
   * exit so that we don't error, but at the same time work where switchroot
   * is PID 1 (and so hasn't created /run/ostree-booted).
   */

@Freyon77
Copy link
Author

So as I understand it this is intentional and will not be corrected? It would be nice if there was an option to mask the error. Well I guess the only solution is to go back to the previous version

@dbnicholson
Copy link
Member

@ericcurtin looks like the aboot systemd generator changes in aa72caf cause the generator to fail on non ostree booting systems. Can you have a look?

cgwalters added a commit to cgwalters/ostree that referenced this issue Jun 28, 2023
@cgwalters
Fix return value of generator on non-ostree systems
3c76d03 
Commit aa72caf
regressed the `ostree-system-generator` on non-ostree systems.
If there's no `ostree=` karg, we need to just exit 0.

Closes: ostreedev#2909
Fixes: aa72caf
@cgwalters cgwalters mentioned this issue Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix return value of generator on non-ostree systems cgwalters/ostree
3 participants
@dbnicholson @chrisawi @Freyon77