Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest ostree broke flatpak #798

Closed
alexlarsson opened this issue Apr 18, 2017 · 1 comment
Closed

Latest ostree broke flatpak #798

alexlarsson opened this issue Apr 18, 2017 · 1 comment
Labels
bug

Comments

@alexlarsson
Copy link
Member

The 2017.4 release broke flatpak: flatpak/flatpak#710

It seems bare-user symlink checkouts are using hardlinks when they should not.
I bisected this to
d3385a3
cgwalters added a commit to cgwalters/ostree that referenced this issue Apr 18, 2017
@cgwalters
checkout: Fix bare-user symlink checkouts
ee918d9 
Logic error introduced after refactoring; we hoisted the
`is_bare_user_symlink` variable to the top, but its computation
below.  But the `is_bare` symlink depended on it.

Closes: ostreedev#798
@cgwalters cgwalters mentioned this issue Apr 18, 2017
Closed
@cgwalters
Copy link
Member

Urg. PR in #799

@jlebon jlebon added the bug label Apr 18, 2017
cgwalters added a commit to cgwalters/ostree that referenced this issue Apr 18, 2017
@cgwalters
Release 2017.5
a9ea38d 
This is a bugfix release for 2017.4 to fix a regression
that broke flatpak: ostreedev#798
@cgwalters cgwalters mentioned this issue Apr 18, 2017
Closed
cgwalters added a commit that referenced this issue Apr 18, 2017
@cgwalters
checkout: Fix bare-user symlink checkouts
53b9b50 
Logic error introduced after refactoring; we hoisted the
`is_bare_user_symlink` variable to the top, but its computation
below.  But the `is_bare` symlink depended on it.

Closes: #798

Closes: #799
Approved by: jlebon
cgwalters added a commit that referenced this issue Apr 18, 2017
@cgwalters
Release 2017.5
65008ed 
This is a bugfix release for 2017.4 to fix a regression
that broke flatpak: #798

See also: #800
Approved by: jlebon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgwalters @alexlarsson @jlebon