core: Add standard SOURCE_TITLE metadata key #1296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Oct 19, 2017
Depends: ostreedev/ostree#1296 As I mention in the commit there, I see two uses for this in rpm-ostree; first in our test suite, and second for OCI-built image imports. I also took a step further here and inject an `original-origin` metadata key, though we aren't actually using that yet. The problem I'm trying to solve there is that repeated `make vmoverlay` starts chaining things up, but that gets very confusing. I think we should always have `vmoverlay` unwind back to the base ref. (Or at least do that by default)
|
rpm-ostree consumption patch: coreos/rpm-ostree#1069 |
|
This is a cool idea! Should we also add a related |
|
I'm not sure...for the OCI case the checksum means a different thing than ostree. For I think my high level feeling here is - let's let the relevant tools add whatever metadata keys are specific to what they're doing, and if there's something to standardize down the line, we circle back here and do that? |
|
But hold off on merging, I'm going to update this PR to also render in |
cgwalters
changed the title
cgwalters
force-pushed
the
commit-source-description
branch
from
21c6f2b
to
f556bcf
Compare
cgwalters
changed the title
No functional changes; prep for more work.
Pull out the commit metadata explicitly; still just rendering the version, but this is prep for rendering other metadata keys.
This is a freeform string useful to track/display when a commit is "derived" from some other format. For example, in the rpm-ostree test we make a `vmcheck` ref that conceptually overlays the default ref like `fedora-atomic:fedora/26/x86_64/atomic-host`. My current patch sets the source title to e.g. "Dev overlay on fedora-atomic:fedora/26/x86_64/atomic-host". Another case I'm working on now is importing OCI images to use as host images. For that case, the source title is With this patch we could then set the original OCI image name + tag as the source name, like: "oci:cgwalters/demo-custom-fedora-atomic-host:26".
cgwalters
force-pushed
the
commit-source-description
branch
from
f556bcf
to
0633aa7
Compare
|
OK, rebased 🏄 and updated with some prep commits and adds testing. Lifting WIP. |
|
Looks good! Though the tests are complaining it seems. |
|
Whee, that was fun. Provoked a uboot integration bug. Fixup ⬆️ |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 23, 2017
Pull out the commit metadata explicitly; still just rendering the version, but this is prep for rendering other metadata keys. Closes: #1296 Approved by: jlebon
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 23, 2017
This is a freeform string useful to track/display when a commit is "derived" from some other format. For example, in the rpm-ostree test we make a `vmcheck` ref that conceptually overlays the default ref like `fedora-atomic:fedora/26/x86_64/atomic-host`. My current patch sets the source title to e.g. "Dev overlay on fedora-atomic:fedora/26/x86_64/atomic-host". Another case I'm working on now is importing OCI images to use as host images. For that case, the source title is With this patch we could then set the original OCI image name + tag as the source name, like: "oci:cgwalters/demo-custom-fedora-atomic-host:26". Closes: #1296 Approved by: jlebon
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Oct 23, 2017
Depends: ostreedev/ostree#1296 As I mention in the commit there, I see two uses for this in rpm-ostree; first in our test suite, and second for OCI-built image imports. I also took a step further here and inject an `original-origin` metadata key, though we aren't actually using that yet. The problem I'm trying to solve there is that repeated `make vmoverlay` starts chaining things up, but that gets very confusing. I think we should always have `vmoverlay` unwind back to the base ref. (Or at least do that by default)
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Oct 24, 2017
Depends: ostreedev/ostree#1296 As I mention in the commit there, I see two uses for this in rpm-ostree; first in our test suite, and second for OCI-built image imports. I also took a step further here and inject an `original-origin` metadata key, though we aren't actually using that yet. The problem I'm trying to solve there is that repeated `make vmoverlay` starts chaining things up, but that gets very confusing. I think we should always have `vmoverlay` unwind back to the base ref. (Or at least do that by default)
rh-atomic-bot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Oct 25, 2017
Depends: ostreedev/ostree#1296 As I mention in the commit there, I see two uses for this in rpm-ostree; first in our test suite, and second for OCI-built image imports. I also took a step further here and inject an `original-origin` metadata key, though we aren't actually using that yet. The problem I'm trying to solve there is that repeated `make vmoverlay` starts chaining things up, but that gets very confusing. I think we should always have `vmoverlay` unwind back to the base ref. (Or at least do that by default) Closes: #1069 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a freeform string useful to track/display when a commit is "derived"
from some other format. For example, in the rpm-ostree test we make a
vmcheckref that conceptually overlays the default ref likefedora-atomic:fedora/26/x86_64/atomic-host.My current patch sets the source title to e.g.
"Dev overlay on fedora-atomic:fedora/26/x86_64/atomic-host".
Another case I'm working on now is importing OCI images to use
as host images. For that case, the source title is
With this patch we could then set the original OCI image name + tag
as the source name, like:
"oci:cgwalters/demo-custom-fedora-atomic-host:26".