Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building without libsoup #1397

Closed
wants to merge 2 commits into from
Closed

Allow building without libsoup #1397

wants to merge 2 commits into from

Conversation

OYTIS
Copy link

@OYTIS OYTIS commented Jan 8, 2018

Signed-off-by: Anton Gerasimov anton.gerasimov@openmailbox.org

@OYTIS
Copy link
Author

OYTIS commented Jan 8, 2018

This is more for discussion than for immediate merger as is. I understand there was probably a good reason to fail in this case, but there are also use cases (like my favourite embedded one) where tests don't matter much and additional dependencies do. Maybe there could be another configure parameter (--without-soup-please or something) for such cases.

@cgwalters
Copy link
Member

cgwalters commented Jan 8, 2018

We could call it --no-soup-for-you!?

But more seriously, I think all I'd like to see in addition to your changes here is some build magic so that make check prints out a warning or something? I can take care of that if you prefer.

@OYTIS
Copy link
Author

OYTIS commented Jan 8, 2018

That would be great, thank you.

cgwalters and others added 2 commits January 8, 2018 09:29
Prep for supporting `--with-curl --without-soup`.
Some people (particularly embedded) may find it simpler to
drop libsoup from the build dependency side, but still use libcurl.

Note though this currently neuters almost all of the tests.

Signed-off-by: Anton Gerasimov <anton.gerasimov@openmailbox.org>
@cgwalters
Copy link
Member

OK, updated ⬆️ - look good to you?

@OYTIS
Copy link
Author

OYTIS commented Jan 8, 2018

Looks good, thank you.

@cgwalters
Copy link
Member

@rh-atomic-bot r+ 1383812

@rh-atomic-bot
Copy link

⌛ Testing commit 1383812 with merge 353fb17...

rh-atomic-bot pushed a commit that referenced this pull request Jan 8, 2018
Some people (particularly embedded) may find it simpler to
drop libsoup from the build dependency side, but still use libcurl.

Note though this currently neuters almost all of the tests.

Signed-off-by: Anton Gerasimov <anton.gerasimov@openmailbox.org>

Closes: #1397
Approved by: cgwalters
@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing 353fb17 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants