-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building without libsoup #1397
Conversation
This is more for discussion than for immediate merger as is. I understand there was probably a good reason to fail in this case, but there are also use cases (like my favourite embedded one) where tests don't matter much and additional dependencies do. Maybe there could be another configure parameter ( |
We could call it But more seriously, I think all I'd like to see in addition to your changes here is some build magic so that |
That would be great, thank you. |
Prep for supporting `--with-curl --without-soup`.
Some people (particularly embedded) may find it simpler to drop libsoup from the build dependency side, but still use libcurl. Note though this currently neuters almost all of the tests. Signed-off-by: Anton Gerasimov <anton.gerasimov@openmailbox.org>
OK, updated ⬆️ - look good to you? |
Looks good, thank you. |
Some people (particularly embedded) may find it simpler to drop libsoup from the build dependency side, but still use libcurl. Note though this currently neuters almost all of the tests. Signed-off-by: Anton Gerasimov <anton.gerasimov@openmailbox.org> Closes: #1397 Approved by: cgwalters
☀️ Test successful - status-atomicjenkins |
Signed-off-by: Anton Gerasimov anton.gerasimov@openmailbox.org