Don't scan uncompressed_objects_dir if it doesn't exist #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A newly created archive-mode repository won't have a uncompressed-objects-cache directory, and uncompressed_objects_dir is -1 to flag that. The special meaning of -1 meaning "cwd" for libglnx means that the current directory was scanned as if it was an objects directory, producing unexpected results, especially if there were any two-letter files/subdirs in the current directory.
|
Can one of the admins verify this patch?
|
|
Thanks! @rh-atomic-bot r+ 0afaf73 The only other place which gave me some hesitation was |
|
Thanks for the review! I agree with your analysis of |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A newly created archive-mode repository won't have a uncompressed-objects-cache
directory, and uncompressed_objects_dir is -1 to flag that. The special meaning of
-1 meaning "cwd" for libglnx means that the current directory was scanned as
if it was an objects directory, producing unexpected results, especially if there
were any two-letter files/subdirs in the current directory.
This fixes a regression from 88d27fb
I didn't examine the source code to see if there were any other places where uncompressed_objects_dir is used blindly.