lib/grub2: Support Debian-style grub.cfg path #1714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian and Debian-derived systems have their GRUB configuration file in /boot/grub/grub.cfg, rather than /boot/grub2/grub.cfg. Detecting this file is necessary to correctly generate GRUB boot configuration on Debian systems.
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch?
|
|
Thanks for the patch! Offhand, I think this is OK as is, though it might be better as a build-time option? Do you have the autotools-fu to do that? |
|
A build-time option would also be fine. But adding an option for such a simple check seems overkill to me? If you prefer the compile option, I can change it. I can probably figure out how to do that with autotools. |
|
Yeah, not worth redoing it. I just pushed a quick |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to... at least Fedora, Debian and Debian-derived systems keep their GRUB configuration file on BIOS systems in
/boot/grub/grub.cfg, rather than/boot/grub2/grub.cfg. This patch changes the GRUB detection to look for either of these parts so that GRUB bootloader generation works as expected when doing anostree admin deployon a Debian system.