deploy: Fix removing /var/.updated with separate /var mount #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some subtlety to this, we don't handle all cases. But the 99% cases are using `--sysroot deploy` to create an initial deployment, and then doing upgrades from inside a booted deployment. It was only the latter case that didn't work with a separate `/var`. Fixing all of them would probably require libostree to learn how to e.g. look at `/etc/fstab` (or worse, systemd mount units?) and handle the mounting. I don't think we want to do anything like that right now, since there are no active drivers for the use case. Closes: ostreedev#1729
|
Just compile/unit tested, but sadly our test suite today doesn't actively exercise split |
|
LGTM |
|
@rh-atomic-bot delegate=akiernan |
|
✌️ @akiernan can now approve this pull request |
akiernan
pushed a commit
to akiernan/meta-ostree-core
that referenced
this pull request
Sep 21, 2018
akiernan
added a commit
to akiernan/meta-ostree-core
that referenced
this pull request
Sep 21, 2018
From upstream: ostreedev/ostree#1730 Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some subtlety to this, we don't handle all cases.
But the 99% cases are using
--sysroot deployto create aninitial deployment, and then doing upgrades from inside
a booted deployment.
It was only the latter case that didn't work with a separate
/var.Fixing all of them would probably require libostree to learn
how to e.g. look at
/etc/fstab(or worse, systemd mount units?)and handle the mounting. I don't think we want to do anything
like that right now, since there are no active drivers for the
use case.
Closes: #1729