Add an "ostree config unset" operation #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively we could consider making |
|
Hmm, but So I think I prefer your idea of |
jlebon
reviewed
Oct 11, 2018
mwleeds
changed the title
|
I don't really have time to work on this right now but just interesting to note, |
Currently there's a way to set a key to the empty string but there's no way to unset it completely (remove the key from the group). This might be helpful for instance if you want to temporarily set "core.lock-timeout-secs" to a specific value for the duration of one operation and then return it to the default after that operation completes. This commit implements an "unset" operation for the config command, adds a unit test, and updates the man page.
It seems cleaner to make the GKeyFile a g_autoptr variable and just return rather than using the "goto out;" idiom.
It doesn't make much sense to use SECTIONNAME in some places and GROUPNAME in others when they mean the same thing.
Currently it's not an error to provide too many arguments to an ostree config command. Change it so we print usage information in that case, and update the unit tests.
mwleeds
force-pushed
the
config-unset-option
branch
from
ab8433c
to
6b417c3
Compare
|
This is ready for re-review now, and has a new commit to check for too many arguments. Sorry for the delay |
mwleeds
changed the title
|
This looks great to me! Will leave it open for a bit to give others time to review. |
rfairley
approved these changes
Mar 1, 2019
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 1, 2019
It seems cleaner to make the GKeyFile a g_autoptr variable and just return rather than using the "goto out;" idiom. Closes: #1743 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 1, 2019
It doesn't make much sense to use SECTIONNAME in some places and GROUPNAME in others when they mean the same thing. Closes: #1743 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 1, 2019
Currently it's not an error to provide too many arguments to an ostree config command. Change it so we print usage information in that case, and update the unit tests. Closes: #1743 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.