Don't delete refs having aliases #1749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Oct 5, 2018
src/ostree/ot-builtin-refs.c
Outdated
| ref_alias, const char *, value) | ||
| { | ||
| if (!strcmp(ref, value)) | ||
| { |
There was a problem hiding this comment.
Damn, fixed it!
Is there an automatic source formatter (config) which I can use during OSTree development?
src/ostree/ot-builtin-refs.c
Outdated
| if (!strcmp(ref, value)) | ||
| { | ||
| g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, | ||
| "Ref %s has some aliases, first delete corresponding aliases", ref); |
There was a problem hiding this comment.
How about: "Ref '%s' has an active alias: '%s'", ref, ref_alias
There was a problem hiding this comment.
Makes sense, updated the error message.
|
This PR has been updated with changes from feedback and ready for further review. |
giuseppe
reviewed
Oct 10, 2018
src/ostree/ot-builtin-refs.c
Outdated
| GLNX_HASH_TABLE_FOREACH_KV (ref_aliases, const char *, | ||
| ref_alias, const char *, value) | ||
| { | ||
| if (!strcmp(ref, value)) |
There was a problem hiding this comment.
nit: missing space between strcmp and '('
There was a problem hiding this comment.
Thanks, fixed it!
Deleting a ref with aliases makes them dangling. In such cases, display an error message to the user. Fixes ostreedev#1597 Signed-off-by: Sinny Kumari <sinny@redhat.com>
|
Nice work @sinnykumari ! |
|
💥 Test timed out |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
|
Thanks @cgwalters ! |
jlebon
added a commit
to jlebon/ostree
that referenced
this pull request
Oct 30, 2018
This is the alias version of ostreedev#1749. I.e. we want to make sure that one can't even create an alias which would end up dangling. See also: https://pagure.io/releng/issue/7891
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 31, 2018
This is the alias version of #1749. I.e. we want to make sure that one can't even create an alias which would end up dangling. See also: https://pagure.io/releng/issue/7891 Closes: #1768 Approved by: sinnykumari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a ref with aliases makes them dangling. In such
cases, display an error message to the user.
Fixes #1597
Signed-off-by: Sinny Kumari sinny@redhat.com