finalize-staged: Bump timeout to 5 minutes #1755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, 10m is pretty generous. What if some subtle other issue is causing us to hang? But then again, the chances of that are pretty low so... maybe it's fine. I'd be interested to hear e.g. what the reporter in coreos/rpm-ostree#1568 found worked for them. I'm wondering if it'd help if we also did a pre-emptive |
|
So, looking at coreos/rpm-ostree#1568, looks like 2m was enough for that user. WDYT about making this 5m for now? |
See coreos/rpm-ostree#1568 Basically for people on e.g. rotational media, the default 90 second timeout can be too small. We're in a tough situation here, because delaying shutdown can be problematic too if the user is trying to shut down their laptop to put in a backpack, etc. There's potential optimizations here to make; I think we could pre-copy the kernel/initramfs for example. I suspect for some people the grub2 os-prober is a factor here too, if that tries to e.g. inspect attached USB rotational hard drives. But hopefully we'll get rid of that soon.
cgwalters
force-pushed
the
finalize-stage-longer-timeout
branch
from
929d9ac
to
bda2dde
Compare
cgwalters
changed the title
|
OK, updated to 5. |
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See coreos/rpm-ostree#1568
Basically for people on e.g. rotational media, the default 90
second timeout can be too small.
We're in a tough situation here, because delaying shutdown
can be problematic too if the user is trying to shut down their
laptop to put in a backpack, etc.
There's potential optimizations here to make; I think we
could pre-copy the kernel/initramfs for example.
I suspect for some people the grub2 os-prober is a factor here too,
if that tries to e.g. inspect attached USB rotational hard drives.
But hopefully we'll get rid of that soon.