ostree-prepare-root.service: Run earlier in initrd #1759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the same reasons as ostreedev#1697. This is especially important in services that are likely to be used as an `After/Before=` target in other units. `ostree-prepare-root.service` is one such service.
Previously, we were preparing the root very late in the boot process; right before we switch root. The issue with that is that most services in the initrd that run `After=initrd-root-fs.target` expect that `/sysroot` already points to the rootfs we'll be pivoting to. Running this late violates that assumption. This patch fixes this by making `ostree-prepare-root.service` instead run right after `sysroot.mount` (the physical sysroot mounted by systemd) but still before `initrd-root-fs.target` (which is the target signalling that `/sysroot` is now valid and ready). This should make it easier to integrate OSTree with other initrd services such as Ignition. Related: https://github.com/dustymabe/ignition-dracut/issues/20
|
Marking as WIP for now, still need to test this on some more platforms. |
|
OK, I've now tested this on FAH, CAHC, FCOS, and RHCOS! ✔️ |
|
@ramcq If you have some time, would be nice to sanity check that this doesn't cause any weird regressions on EOS either. |
|
⚡ Test exempted: merge already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Oct 19, 2018
Previously, we were preparing the root very late in the boot process; right before we switch root. The issue with that is that most services in the initrd that run `After=initrd-root-fs.target` expect that `/sysroot` already points to the rootfs we'll be pivoting to. Running this late violates that assumption. This patch fixes this by making `ostree-prepare-root.service` instead run right after `sysroot.mount` (the physical sysroot mounted by systemd) but still before `initrd-root-fs.target` (which is the target signalling that `/sysroot` is now valid and ready). This should make it easier to integrate OSTree with other initrd services such as Ignition. Related: https://github.com/dustymabe/ignition-dracut/issues/20 Closes: #1759 Approved by: cgwalters
|
We do have a couple initrd services in https://github.com/endlessm/eos-boot-helper/tree/master/dracut that depend on the mount ordering. I haven't looked closely at the ordering yet. @dsd FYI. |
mbilker
pushed a commit
to mbilker/ostree
that referenced
this pull request
Aug 25, 2020
- Fixes systemd failing to determine if `/sysroot` is valid because of `/etc/os-release` not being available yet. - Related: ostreedev#1759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were preparing the root very late in the boot process;
right before we switch root. The issue with that is that most services
in the initrd that run
After=initrd-root-fs.targetexpect that/sysrootalready points to the rootfs we'll be pivoting to. Runningthis late violates that assumption.
This patch fixes this by making
ostree-prepare-root.serviceinsteadrun right after
sysroot.mount(the physical sysroot mounted bysystemd) but still before
initrd-root-fs.target(which is the targetsignalling that
/sysrootis now valid and ready).This should make it easier to integrate OSTree with other initrd
services such as Ignition.
Related: dustymabe/ignition-dracut#20