-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2018.9 #1761
Release 2018.9 #1761
Conversation
This will have to be redone if #1763 is merged. Sorry about that. |
Looks like it's approved but not merged due to some internal error. I'll check again after some time. |
☔ The latest upstream changes (presumably ed41822) made this pull request unmergeable. Please resolve the merge conflicts. |
Nothing from me. |
ff0f4db
to
b0eedc9
Compare
Updated the PR. |
Thanks. @uajain what time zone are you in? Often jlebon and I set up an etherpad where we write release notes together. Both of us are in EST. Do you want to participate in that too? If so, would say 2-3pm EST tomorrow work? |
Hey, @cgwalters I am in India (UTC +5:30) timezone, so I don't think that time suits me. However, I am happy to get involved asynchronously for any matter. |
Hm, some test flakes there. But let's do this: We can get the release commit merged, and I'll post a link to an etherpad here for us to collaborate on release notes and then take care of pushing the tag. |
Closes: #1761 Approved by: cgwalters
Closes: #1761 Approved by: cgwalters
💔 Test failed - status-atomicjenkins |
Fix in #1765. |
Wrap the `Version` key in the YAML-compatible output of `ostree --version` with quotes so that it's parsed as a string. The issues with the previous approach in a nutshell: ``` In [5]: yaml.load("asdf: 2018.10") Out[5]: {'asdf': 2018.1} ``` It's treating the version number as a floating-point. Now, this is technically a backwards incompatible change, but given that the previous approach is inherently broken for our needs, I don't see a way around breaking it now.
e6eff5d
to
362e7ea
Compare
📌 Commit 362e7ea has been approved by |
Closes: #1761 Approved by: cgwalters
Wrap the `Version` key in the YAML-compatible output of `ostree --version` with quotes so that it's parsed as a string. The issues with the previous approach in a nutshell: ``` In [5]: yaml.load("asdf: 2018.10") Out[5]: {'asdf': 2018.1} ``` It's treating the version number as a floating-point. Now, this is technically a backwards incompatible change, but given that the previous approach is inherently broken for our needs, I don't see a way around breaking it now. Closes: #1761 Approved by: cgwalters
Hmm, although the commit is after the release commit right? Probably need to rebase it to before? |
We could do that. Though note whatever out there was relying on this before should just keep working in this release because |
☀️ Test successful - status-atomicjenkins |
I didn't start on the rest of release yet (relnotes/tag etc)...will look at this tomorrow. |
Set up an etherpad for this release: https://public.etherpad-mozilla.org/p/ostree-2018.9 |
No description provided.