-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/kargs: allow empty-list arguments #1785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Just one small indentation nit.
Yep, LGTM otherwise. I tried to push a
Do you explicitly uncheck the "allow pushes to your PR" box? |
This adds support for empty-list arguments (e.g. `acpi_osi=`), which are semantically different from simple-keyword arguments. Ref: coreos/rpm-ostree#1706
be4faba
to
ba0645c
Compare
@cgwalters nothing specific on this PR/branch (maybe some other default?). Also, the "allow edits from maintainers" box is checked here. Not sure why you can't push. |
thanks @lucab |
(Side note, this module looks like a good low hanging fruit candidate for oxidation, in case there are future plans for that) |
☀️ Test successful - status-atomicjenkins |
I think we should raise that on the mailing list...it was last discussed nearly 2 years ago. I am obviously in favor of oxidizing more here but I want to be sure enough of our users are ready for it. |
Potential regression: https://pagure.io/teamsilverblue/issue/66 |
@jlebon likely correlated, yes. However the test cases in this PR should be exercising that exact codepath. |
This is essentially a copy of ostreedev/ostree#1785 to our private copy of the kargs API. Should really dedupe those... The really confusing part though was that that patch was intended to fix the `rpm-ostree kargs --append EMPTYKEY=` case (coreos#1706), yet the `rpmostree kargs --append KEYWORD` case (coreos#1779) wasn't also fixed, even though that same ostree patch clearly fixes and tests for that too. To make a long story short, we were passing buggy kargs to ostree, which before that patch, had itself buggy kargs parsing which conveniently fixed back the kargs we passed for the `KEYWORD` case. Closes: coreos#1779
This is essentially a copy of ostreedev/ostree#1785 to our private copy of the kargs API. Should really dedupe those... The really confusing part though was that that patch was intended to fix the `rpm-ostree kargs --append EMPTYKEY=` case (#1706), yet the `rpmostree kargs --append KEYWORD` case (#1779) wasn't also fixed, even though that same ostree patch clearly fixes and tests for that too. To make a long story short, we were passing buggy kargs to ostree, which before that patch, had itself buggy kargs parsing which conveniently fixed back the kargs we passed for the `KEYWORD` case. Closes: #1779 Closes: #1796 Approved by: cgwalters
This adds support for empty-list arguments (e.g.
acpi_osi=
), whichare semantically different from simple-keyword arguments.
Ref: coreos/rpm-ostree#1706