Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub2: add support for devicetree #1790

Closed
wants to merge 2 commits into from
Closed

grub2: add support for devicetree #1790

wants to merge 2 commits into from

Conversation

ricardosalveti
Copy link
Contributor

Similar as available for u-boot (ce2995e)
and syslinux (c5112c2), enable parsing
and writing devicetree filename into grub.cfg.

This is required by arm64-based devices running edk2 instead of u-boot
as the main bootloader (e.g. 96boards HiKey and HiKey960).

Signed-off-by: Ricardo Salveti ricardo@foundries.io

@ricardosalveti
grub2: add support for devicetree
21b60af 
Similar as available for u-boot (ce2995e)
and syslinux (c5112c2), enable parsing
and writing devicetree filename into grub.cfg.

This is required by arm64-based devices running edk2 instead of u-boot
as the main bootloader (e.g. 96boards HiKey and HiKey960).

Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
@papr-bot
Copy link

Can one of the admins verify this patch?

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@jlebon
Copy link
Member

jlebon commented Dec 20, 2018

bot, test pull request

@jlebon
Copy link
Member

jlebon commented Dec 20, 2018

Thanks for the patch!
This looks sane to me, though will let @cgwalters have a look.

@cgwalters
Copy link
Member

Also can you clarify whether you tested this using the direct shell ostree-grub-generator backend or the full grub2-mkconfig path? (It's totally fine to have only tested one path, would just be helpful to know)

@ricardosalveti
Copy link
Contributor Author

Also can you clarify whether you tested this using the direct shell ostree-grub-generator backend or the full grub2-mkconfig path? (It's totally fine to have only tested one path, would just be helpful to know)

Tested with ostree-grub-generator only.

@cgwalters
Copy link
Member

Thanks for the patch!

@rh-atomic-bot r+ 7dfe90b

@rh-atomic-bot
Copy link

⌛ Testing commit 7dfe90b with merge b6795c9...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing b6795c9 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ricardosalveti @papr-bot @rh-atomic-bot @jlebon @cgwalters