Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boot: Activate ostree-finalize-staged even earlier #1840

Closed
wants to merge 1 commit into from
Closed

boot: Activate ostree-finalize-staged even earlier #1840

wants to merge 1 commit into from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Apr 12, 2019

Really, all ostree admin finalize-staged needs is access to /sysroot
and /boot. So let's activate it right after local-fs.target so that
it gets deactivated later in the shutdown process. This should allow us
to conflict with less services still running and possibly writing things
to /etc.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1672283

@jlebon
boot: Activate ostree-finalize-staged even earlier
a995074 
Really, all `ostree admin finalize-staged` needs is access to `/sysroot`
and `/boot`. So let's activate it right after `local-fs.target` so that
it gets deactivated later in the shutdown process. This should allow us
to conflict with less services still running and possibly writing things
to `/etc`.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1672283
@jlebon jlebon changed the title WIP: boot: Activate ostree-finalize-staged even earlier boot: Activate ostree-finalize-staged even earlier Apr 12, 2019
@jlebon
Copy link
Member Author

jlebon commented Apr 12, 2019

Seems to work well:

...
Apr 12 18:02:01 f29-ros systemd[1]: Stopped target Basic System.
Apr 12 18:02:01 f29-ros systemd[1]: Stopped target Paths.
Apr 12 18:02:01 f29-ros systemd[1]: Stopped target Sockets.
Apr 12 18:02:01 f29-ros systemd[1]: Stopped target Slices.
Apr 12 18:02:01 f29-ros systemd[1]: Removed slice User and Session Slice.
Apr 12 18:02:01 f29-ros systemd[1]: Stopping OSTree Finalize Staged Deployment...
...
Apr 12 18:02:03 f29-ros ostree[3192]: Copying /etc changes: 15 modified, 0 removed, 64 added
Apr 12 18:02:03 f29-ros ostree[3192]: Transaction complete; bootconfig swap: no; deployment count change: 0
Apr 12 18:02:04 f29-ros systemd[1]: Stopped OSTree Finalize Staged Deployment.
Apr 12 18:02:04 f29-ros umount[3199]: umount: /var: target is busy.
Apr 12 18:02:04 f29-ros systemd[1]: Stopped target Local File Systems.
Apr 12 18:02:04 f29-ros systemd[1]: Unmounting /boot...
Apr 12 18:02:04 f29-ros systemd[1]: Unmounting /var...
Apr 12 18:02:04 f29-ros systemd[1]: var.mount: Mount process exited, code=exited status=32
Apr 12 18:02:04 f29-ros systemd[1]: Failed unmounting /var.
Apr 12 18:02:04 f29-ros systemd[1]: Unmounting /sysroot...

(The /var umount issue is an old one and unrelated. IIRC it's from the journal keeping it busy.)

@cgwalters
Copy link
Member

@rh-atomic-bot r+ a995074

@rh-atomic-bot
Copy link

⚡ Test exempted: merge already tested.

@jlebon jlebon mentioned this pull request May 14, 2019
Open
@jlebon jlebon deleted the pr/stage-later branch April 24, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlebon @cgwalters @rh-atomic-bot