Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't copy summary for collection-ref mirror subset pulls #1973

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Don't copy summary for collection-ref mirror subset pulls #1973

merged 2 commits into from
Mar 29, 2020

Commits on Mar 28, 2020

  1. find-remotes: Add a --mirror option 

    This will be useful in the unit test added by the next commit. It just
passes OSTREE_REPO_PULL_FLAGS_MIRROR to the call to
ostree_repo_pull_from_remotes_async().
    @mwleeds
    mwleeds committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    cd37293 View commit details
    Browse the repository at this point in the history

  2. Don't copy summary for collection-ref mirror subset pulls 

    When we're only pulling a subset of the refs available in the remote, it
doesn't make sense to copy the remote's summary (which may not be valid
for the local repo). This makes the check here match the one done
several lines above when we decide whether to error out if there's no
remote summary available.

This extends the fix in ostreedev#935 for
the case of collection-refs.

Also, add a unit test for this issue, based on the existing one in
pull-test.sh.
    @mwleeds
    mwleeds committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    164b2aa View commit details
    Browse the repository at this point in the history