pull: Add summary-{,sig-}bytes options to ostree_repo_pull() #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backticks improve all things. Signed-off-by: Philip Withnall <withnall@endlessm.com>
These allow the `summary` and `summary.sig` files to be cached at a higher layer (for example, flatpak) between related pull operations (for example, within a single flatpak transaction). This avoids re-downloading `summary.sig` multiple times throughout a transaction, which increases the transaction’s latency and introduces the possibility for inconsistency between parts of the transaction if the server changes its `summary` file part-way through. In particular, this should speed up flatpak transactions on machines with high latency network connections, where network round trips have a high impact on the latency of an overall operation. Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
See also #2165 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, pwithnall The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allow the
summaryandsummary.sigfiles to be cached at ahigher layer (for example, flatpak) between related pull operations (for
example, within a single flatpak transaction). This avoids
re-downloading
summary.sigmultiple times throughout a transaction,which increases the transaction’s latency and introduces the possibility
for inconsistency between parts of the transaction if the server changes
its
summaryfile part-way through.In particular, this should speed up flatpak transactions on machines
with high latency network connections, where network round trips have a
high impact on the latency of an overall operation.
Signed-off-by: Philip Withnall withnall@endlessm.com