Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: regenerate bindings after latest release (2022.6) #2742

Merged
merged 3 commits into from
Oct 26, 2022
Merged

rust: regenerate bindings after latest release (2022.6) #2742

merged 3 commits into from
Oct 26, 2022

Conversation

lucab
Copy link
Member

@lucab lucab commented Oct 24, 2022 •
edited
Loading

This updates Rust binding to latest libostree release 2022.6.
It also contains version bumps for crates ostree-sys 0.11.0 and ostree 0.16.0

@lucab lucab force-pushed the ups/rust-regenerate-2022.6 branch from c5c12ad to 4a106ce Compare October 25, 2022 16:11
cgwalters
cgwalters previously approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though note the semver bump here ripples through higher level things.

In the future I'd like to consider trying to e.g. batch this change with things like updating to the latest gtk-rs (also a semver bump).

But, LGTM as is.

@lucab lucab force-pushed the ups/rust-regenerate-2022.6 branch from 4a106ce to d65d3fb Compare October 26, 2022 06:47
@lucab
Copy link
Member Author

lucab commented Oct 26, 2022

Fair point. For the moment I've dropped the last commit from here, which was bumping the versions in Cargo.toml.
There is another semver bump upcoming for #2647.
I wasn't sure how much work that would be, but I think I already managed to complete the porting at #2743.
We can decide to directly jump to that and tag the new semver-breaking releases already with the new gtk-rs requirements.

@lucab lucab requested a review from cgwalters October 26, 2022 06:56
lucab added 3 commits October 26, 2022 09:26
@lucab
rust: regenerate bindings after latest release (2022.6)
f689ca0
@lucab
ostree: manually patch generated files
6aa7d6e 
This manually adds a missing `ToGlibPtr` import, which seems to be result
of some bugs in `gir` code-generation.
@lucab
rust: update manual helpers
10cecd7
@lucab lucab force-pushed the ups/rust-regenerate-2022.6 branch from d65d3fb to 10cecd7 Compare October 26, 2022 09:27
cgwalters
cgwalters approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgwalters cgwalters merged commit 1258c37 into ostreedev:main Oct 26, 2022
@lucab lucab deleted the ups/rust-regenerate-2022.6 branch October 26, 2022 13:31
@lucab lucab mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucab @cgwalters