configure: use pkg-config with newer gpgme and gpg-error #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't look closely, but I agree with this in principle. There's at least one open issue about this. I can take a closer look after the US holiday if no one gets to it earlier. |
|
This is meant to fix the recent CI failure on Debian testing, which I think is due to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1023601. |
lucab
commented
Nov 24, 2022
lucab
force-pushed
the
ups/autoconf-gpg-libs
branch
from
edb55cb
to
c60a3e0
Compare
|
One nit from
|
cgwalters
approved these changes
Nov 28, 2022
This tweaks autoconf logic in order to use pkg-config for gpgme and gpg-error when available. Recent versions of gpgme directly provide threaded support, and gpg-error started shipping a .pc file. Thus on recent distributions it is possible to directly use pkg-config for both. On older environments, the legacy logic is kept in place.
This silences a warning when building the project with `--with-gpme=no`.
lucab
force-pushed
the
ups/autoconf-gpg-libs
branch
from
c60a3e0
to
fa6064b
Compare
raspbian-autopush
pushed a commit
to raspbian-packages/ostree
that referenced
this pull request
Dec 13, 2022
This tweaks autoconf logic in order to use pkg-config for gpgme and gpg-error when available. Recent versions of gpgme directly provide threaded support, and gpg-error started shipping a .pc file. Thus on recent distributions it is possible to directly use pkg-config for both. On older environments, the legacy logic is kept in place. Forwarded: ostreedev/ostree#2789 Gbp-Pq: Name configure-use-pkg-config-with-newer-gpgme-and-gpg-error.patch
raspbian-autopush
pushed a commit
to raspbian-packages/ostree
that referenced
this pull request
Dec 13, 2022
This tweaks autoconf logic in order to use pkg-config for gpgme and gpg-error when available. Recent versions of gpgme directly provide threaded support, and gpg-error started shipping a .pc file. Thus on recent distributions it is possible to directly use pkg-config for both. On older environments, the legacy logic is kept in place. Forwarded: ostreedev/ostree#2789 Gbp-Pq: Name configure-use-pkg-config-with-newer-gpgme-and-gpg-error.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks autoconf logic in order to use pkg-config for gpgme and gpg-error when available.
Recent versions of gpgme directly provide threaded support, and gpg-error started shipping a .pc file. Thus on recent distributions it is possible to directly use pkg-config for both. On older environments, the legacy logic is kept in place.