Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/sysroot-upgrader: add some 'nullable' annotations #2792

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

lucab
Copy link
Member

@lucab lucab commented Dec 2, 2022

No description provided.

@cgwalters
Copy link
Member

Run cd tests/inst && cargo build --verbose --release
    Updating crates.io index
    Updating git repository `[https://github.com/coreos/rpm-ostree`](https://github.com/coreos/rpm-ostree%60)
    Updating git submodule `[https://github.com/rpm-software-management/libdnf`](https://github.com/rpm-software-management/libdnf%60)
    Updating git submodule `[https://gitlab.gnome.org/GNOME/libglnx.git`](https://gitlab.gnome.org/GNOME/libglnx.git%60)
    Updating git repository `[https://github.com/cgwalters/with-procspawn-tempdir`](https://github.com/cgwalters/with-procspawn-tempdir%60)
error: failed to select a version for the requirement `hyper-staticfile = "^0.6.0"`
candidate versions found which didn't match: 0.9.2
location searched: crates.io index
required by package `ostree-test v0.1.0 (/__w/ostree/ostree/tests/inst)`
Error: Process completed with exit code 101.

Hum...it sure looks to me like the hyper-staticfile just yanked all prior versions. That's rather unfriendly.

@lucab
Copy link
Member Author

lucab commented Dec 2, 2022

@cgwalters it looks like the test crate here is an application, but it is lacking its lockfile. If you still have one around, you can commit it and the yanked library will work again. Otherwise we'll need to update the dependency first.

@cgwalters
Copy link
Member

True...we could think of it as an app. That said, yanking IMO should only be used when there's a reason - I filed:
stephank/hyper-staticfile#37

@dbnicholson
Copy link
Member

I fixed the hyper-staticfile issue in #2807. I think if you rebase it will go through again.

@lucab
Copy link
Member Author

lucab commented Feb 8, 2023

Rebased.

@lucab lucab enabled auto-merge February 8, 2023 16:30
@lucab lucab merged commit 51f3d03 into ostreedev:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants