Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libostree: Enhance the annotation coverage #2814

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

tintou
Copy link
Contributor

@tintou tintou commented Feb 9, 2023

Increase the coverage of the GObject Introspection annotation and most notably replace the use of "allow-none" with "out" parameters to "nullable" or "optional" as the previous annotation is deprecated and ambiguous.

Increase the coverage of the GObject Introspection annotation and most notably
replace the use of "allow-none" with "out" parameters to "nullable" or "optional"
as the previous annotation is deprecated and ambiguous.
@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

Hi @tintou. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

Thanks for the patch! Some overlap here with #2791 right?

@tintou
Copy link
Contributor Author

tintou commented Feb 9, 2023

This would probably help this PR indeed

@cgwalters
Copy link
Member

OK before we do another semver bump I'd like to get a release out with current fixes for 0.17 #2818

@tintou
Copy link
Contributor Author

tintou commented Mar 14, 2023

I guess that this can be merged now?

@cgwalters
Copy link
Member

/ok-to-test

@cgwalters
Copy link
Member

/override continuous-integration/jenkins/pr-merge

@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Member

/override ci/prow/sanity

@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/sanity

In response to this:

/override ci/prow/sanity

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgwalters cgwalters merged commit c0427ec into ostreedev:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants