-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composefs followups #2872
Composefs followups #2872
Conversation
Seen in review.
To keep the error messages consistent.
src/switchroot/ostree-prepare-root.c
Outdated
else | ||
{ | ||
#ifdef USE_LIBSYSTEMD | ||
sd_journal_send ("MESSAGE=Mounted composefs (signed: %d)", (int)using_composefs_signature, NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not quite right. using_composefs_signature is only set if we applied the signature this boot, which only happens on the first boot of this deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just drop that part, i'm looking at reworking the signature handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, dropped.
- Hoist the `.ostree.cfs` to a shared constant - Add more logging in general for extra visibility
a34d60f
to
12b7f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mount-util: Add missing O_CLOEXEC
Seen in review.
composefs: Factor out a shared helper for setting error
To keep the error messages consistent.