Composefs followups #2872
Merged
Composefs followups #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen in review.
To keep the error messages consistent.
alexlarsson
reviewed
Jun 5, 2023
src/switchroot/ostree-prepare-root.c
Outdated
| else | ||
| { | ||
| #ifdef USE_LIBSYSTEMD | ||
| sd_journal_send ("MESSAGE=Mounted composefs (signed: %d)", (int)using_composefs_signature, NULL); |
There was a problem hiding this comment.
This is not quite right. using_composefs_signature is only set if we applied the signature this boot, which only happens on the first boot of this deployment.
There was a problem hiding this comment.
Maybe just drop that part, i'm looking at reworking the signature handling.
- Hoist the `.ostree.cfs` to a shared constant - Add more logging in general for extra visibility
cgwalters
force-pushed
the
composefs-followups
branch
from
a34d60f
to
12b7f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mount-util: Add missing O_CLOEXEC
Seen in review.
composefs: Factor out a shared helper for setting error
To keep the error messages consistent.