fetcher: Always open tmpfiles in repo location #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an installation environment (like a live ISO) we may not have significant space outside of the target installation repository. There's no reason not to always open a linkable tempfile. In the future we should fix the pull path to verify the checksum and then just directly link in the object instead of copying. Closes: ostreedev#2571
|
(Only compile tested locally) |
dbnicholson
approved these changes
Jun 7, 2023
| @@ -35,14 +35,8 @@ static inline gboolean | |||
| _ostree_fetcher_tmpf_from_flags (OstreeFetcherRequestFlags flags, int dfd, GLnxTmpfile *tmpf, | |||
| GError **error) | |||
| { | |||
| if ((flags & OSTREE_FETCHER_REQUEST_LINKABLE) > 0) | |||
There was a problem hiding this comment.
It looks like this is a dead flag with this removal. Since this is internal API (I think), can it be removed?
There was a problem hiding this comment.
Yeah, I felt it was clearer to keep the flag even if unused just to clarify the simplicity of the change.
May do some other cleanup though after this.
|
This was reverted in 4e61e6f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an installation environment (like a live ISO) we may not have significant space outside of the target installation repository.
There's no reason not to always open a linkable tempfile. In the future we should fix the pull path to verify the checksum and then just directly link in the object instead of copying.
Closes: #2571