test-concurrency: Don't lower timeout #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think there's never been a real race condition here. Instead the problem is: - We have a timeout on the lock, after which we error out (30s) - This test actually *lowers* the timeout Looking through the failures for test-concurrency what I see is `error: Locking repo exclusive failed: Resource temporarily unavailable` which is us hitting the timeout. Hardcoded timeouts are just going to be subject to race conditions. I understand not wanting to block forever in some cases, but any arbitrary timeout is just going to get hit in real world conditions too. Anyways for now, stop shooting ourselves in the foot and at least keep the timeout at the default. Closes: ostreedev#2038
dbnicholson
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's never been a real race condition here. Instead the problem is:
Looking through the failures for test-concurrency what I see is
error: Locking repo exclusive failed: Resource temporarily unavailablewhich is us hitting the timeout.Hardcoded timeouts are just going to be subject to race conditions. I understand not wanting to block forever in some cases, but any arbitrary timeout is just going to get hit in real world conditions too.
Anyways for now, stop shooting ourselves in the foot and at least keep the timeout at the default.
Closes: #2038