composefs: Avoid double unref #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrero
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
linter complaining
[2023-06-16T18:54:35.455Z] src/libostree/ostree-repo-composefs.c:464:31: error: code should be clang-formatted [-Wclang-format-violations]
[2023-06-16T18:54:35.455Z] /* Freed by iter-loop */
[2023-06-16T18:54:35.455Z] ^
[2023-06-16T18:54:35.455Z] src/libostree/ostree-repo-composefs.c:465:32: error: code should be clang-formatted [-Wclang-format-violations]
[2023-06-16T18:54:35.455Z] subdirtree_csum_v = NULL;
[2023-06-16T18:54:35.455Z] ^
otherwise lgtm
The interaction of `iter_loop` and autofree is way too subtle; I happened to be reading this code and noticed we did the NULL reset in one path but not another. The real fix is Rust...
cgwalters
force-pushed
the
composefs-err-frees
branch
from
59df531
to
79adcce
Compare
cgwalters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction of
iter_loopand autofree is way too subtle; I happened to be reading this code and noticed we did the NULL reset in one path but not another.The real fix is Rust...