Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Rework composefs metadata, drop custom signatures #2891

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Jun 16, 2023

lib: Rework composefs metadata, drop custom signatures

We will be switching to handling signature verification of
the target ostree commit.


@cgwalters cgwalters marked this pull request as draft June 16, 2023 19:53
@cgwalters cgwalters force-pushed the commit-compute-composefs-digest branch 2 times, most recently from 1ea50d0 to 604e4a3 Compare June 17, 2023 15:46
@cgwalters cgwalters changed the title wip: Add public api for injecting composefs metadata composefs: Start reworking signature support Jun 17, 2023
@cgwalters cgwalters force-pushed the commit-compute-composefs-digest branch from 604e4a3 to 6bdf270 Compare June 17, 2023 21:04
@cgwalters cgwalters changed the title composefs: Start reworking signature support lib: Rework composefs metadata, drop custom signatures Jun 17, 2023
@cgwalters cgwalters marked this pull request as ready for review June 17, 2023 21:05
We will be switching to handling signature verification of
the target ostree commit.
@cgwalters cgwalters force-pushed the commit-compute-composefs-digest branch from 6bdf270 to a6f2d05 Compare June 17, 2023 21:08
@cgwalters cgwalters added the area/composefs Issues related to composefs label Jun 19, 2023
- fix URL
- Document requirements
- Document kernel argument
- Adjust for recent changes

- `CONFIG_OVERLAY_FS`
- `CONFIG_BLK_DEV_LOOP`
- `CONFIG_EROFS_FS`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need config for fs-verity too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not technically a requirement right now is what I was getting at. (Hmm, we should probably have this in upstream composefs actually)

Copy link
Member

@alexlarsson alexlarsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit a113b2b into ostreedev:main Jun 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/composefs Issues related to composefs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants