Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: Add bootloader-naming-2 opt-in #3007

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

cgwalters
Copy link
Member

I've verified that this fixes compatibility with GRUB, which parses the filename:
#2961

However, out of a large degree of conservatism I've made this an opt-in behavior for now.

My plan is to test it out in the FCOS development streams first.

I've verified that this fixes compatibility with GRUB, which
parses the filename:
ostreedev#2961

However, out of a large degree of conservatism I've made this
an opt-in behavior for now.

My plan is to test it out in the FCOS development streams first.
@cgwalters cgwalters marked this pull request as ready for review August 24, 2023 13:42
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cgwalters cgwalters mentioned this pull request Aug 24, 2023
@cgwalters cgwalters changed the title deploy: Add bootloader-naming-2 opt-init deploy: Add bootloader-naming-2 opt-in Aug 24, 2023
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit bcd4d02 into ostreedev:main Aug 24, 2023
23 checks passed
cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this pull request Nov 8, 2023
- This removes the autoprune stuff which is already always on in ostree now
- Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this pull request Nov 8, 2023
- This removes the autoprune stuff which is already always on in ostree now
- Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
@dustymabe
Copy link
Contributor

Looks good:

[core@cosa-devsh ~]$ ls /boot/loader/entries/
ostree-1.conf  ostree-2.conf
[core@cosa-devsh ~]$ rpm-ostree status 
State: idle
Deployments:
● fedora-compose:fedora/x86_64/coreos/rawhide
                  Version: 40.20231108.91.0 (2023-11-08T12:47:04Z)
                   Commit: a8f7ddc642f751e71ba514d3b2a94e8944360352fda9349fa5d12a3e72a572cf
             GPGSignature: Valid signature by 115DF9AEF857853EE8445D0A0727707EA15B79CC

  fedora:fedora/x86_64/coreos/rawhide
                  Version: 40.20231109.dev.0 (2023-11-09T19:45:24Z)
                   Commit: 8d5f9ca25e88b8c9062dfd39c4abf076641975b8744de56a3de4ab23bad6629f
             GPGSignature: (unsigned)

cgwalters added a commit to cgwalters/fedora-coreos-config that referenced this pull request Nov 9, 2023
- This removes the autoprune stuff which is already always on in ostree now
- Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this pull request Nov 9, 2023
- This removes the autoprune stuff which is already always on in ostree now
- Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
aaradhak pushed a commit to aaradhak/fedora-coreos-config that referenced this pull request Mar 18, 2024
- This removes the autoprune stuff which is already always on in ostree now
- Add the new "experiment" of bootloader-naming-2; xref ostreedev/ostree#3007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants