sysroot: Promote the "early prune" behavior to default #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
default-early-prune
branch
from
aa31142
to
9fed6f5
Compare
I think we have enough testing for this, let's default it to on, and change the variable to allow opt-out in case it does introduce a regression.
cgwalters
force-pushed
the
default-early-prune
branch
from
9fed6f5
to
d5cfbed
Compare
|
OK, found the other place in the test that needed to opt-out to verify the old behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we have enough testing for this, let's default it to on, and change the variable to allow opt-out in case it does introduce a regression.