Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutable-tree: Quiet clang-analyzer warning #3019

Merged
merged 1 commit into from
Aug 29, 2023
Merged

mutable-tree: Quiet clang-analyzer warning #3019

merged 1 commit into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. mutable-tree: Quiet clang-analyzer warning 

    The warning here was about a use-after-free which is serious, but
I don't think it was reachable in practice, because we'd only
enter the second conditional if `contents_checksum != self->contents_checksum`,
yet we made them the same thing here.

Nevertheless, refactor the code to do a direct return in this
case because that's basically what happened before, and doing
so is a lot clearer.
    @cgwalters
    cgwalters committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    db4ca6e View commit details
    Browse the repository at this point in the history