Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang analyzer fixes 5 #3024

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Clang analyzer fixes 5 #3024

merged 2 commits into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. keyfile-utils: Quiet a clang-analyzer warning 

    It complains that we could leak memory if the return value
pointer isn't set.  That's actually a nonsensical case, there's
no reason to call this and ignore the return value.

So change things to require it be set, and also change the
`g_return_val_if_fail` to be hard assertions per our new policy.
    @cgwalters
    cgwalters committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5e1b698 View commit details
    Browse the repository at this point in the history

  2. commit: Quiet clang-analyzer warning 

    Another conditional ownership.
    @cgwalters
    cgwalters committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4eb3cac View commit details
    Browse the repository at this point in the history