Drop cap-std from our public APIs #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added
area/rust-bindings
cgwalters
force-pushed
the
drop-cap-std-public
branch
2 times, most recently
from
29df5bf
to
135b40c
Compare
Since it bumped semver (when I didn't expect it to; xref bytecodealliance/cap-std@963eebf#r121651362 It's not load-bearing enough here to matter versus just passing an untyped file descriptor. This mainly means that it will be the `glib` ecosystem which forces transitive semver bumps for us, not both.
To pick up the new `AsFd` etc.
cgwalters
force-pushed
the
drop-cap-std-public
branch
from
8c1b148
to
242a901
Compare
And drop another hardcoded MSRV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it bumped semver (when I didn't expect it to; xref bytecodealliance/cap-std@963eebf#r121651362
It's not load-bearing enough here to matter versus just passing an untyped file descriptor.
This mainly means that it will be the
glibecosystem which forces transitive semver bumps for us, not both.